December 2005 Archives by thread

• Messages sorted by: [ subject ] [ author ] [ date ]
• More info on this list...

Starting: Tue Dec 27 14:10:47 CEST 2005
Ending: Wed Dec 28 16:46:18 CEST 2005
Messages: 28

• [Svnwatch] SSHKeychain 67 Don't over-retain the NSMutableArray and NSArrays in -[SSHAgent currentKeysOnAgent]. Closes #28.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 68 Manage the NSMutableArray of paths better to prevent it from leaking, and use a more idiomatic iteration style to populate it. Closes #29.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 69 Fix several nasty memory management issues in the SSHKeychain class, including a leak in -[SSHKeychain setAgentSocketPath:]. Closes #30.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 70 Ensure fds is always freed before returning. Closes #31.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 71 Ensure -[TunnelsView loadPreferences] does not leak ''tunnels'' when called a second time. TunnelsView now also preserves the current tunnel selection across uses. Closes #32.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 72 Simplify memory management in -[EnvironmentView loadPreferences] and plug memory leaks in the process. Closes #33.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 73 Simplify memory management and fix over-retain in -[EnvironmentView syncEnvironment]. Closes #34.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 74 Rename SSHKey's fullpath to fullPath for consistency, and add -[SSHKey dealloc] to ensure fullPath isn't leaked. Closes #35.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 75 Prefer -[NSString fileSystemRepresentation] over deprecated -[NSString cString] when passing down to BSD APIs dealing with paths. Closes #36.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 76 Replace uses of -[NSString cString] + strstr/strcmp with their NSString equivalents. Closes #37.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 77 Run a quick spaces -> tabs conversion on all source files for consistencies sake. Updated the Xcode project to have all source files use tabs for indentation in preference to the users default setting to make it less likely spaces will creep in again. Closes #38.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 78 Replace uses of -[NSString cString] with -[NSString UTF8String] where appropriate. Closes #39.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 79 Fix off-by-one error in -[SSHKeychain keyAtIndex:]. Closes #40.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 80 Remove unused variables and ensure variables are initialized before use to prevent GCC warnings. While doing this I simplified the nested-ifs in the start of -[Controller askPassphrase:withInteraction:] to make it more obvious which conditions lead to which variables being set.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 81 Refactor -[SSHAgent checkAgent] to make the logic more obvious. This revealed a bug where stopping + restarting the agent would result in it checkAgent deciding the agent had unexpectedly quit and prompting the user, even though a new agent had already been started in its place.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 82 Remove the mysteriously unuseful openPanel and corresponding lock from SSHAgent. It's only set in a single place, and never accessed again. Odd.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 83 Update name of thePid and related to reflect that PID is an acronym. Add consistent getters + setters for member variables.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 84 Make use of the getters/setters throughout SSHAgent.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 85 There's no need for one lock per member variable. Using a single lock for the getter/setters cleans the code up a little more.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 86 Don't leak member variables on deallocation, should it ever happen.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 87 Cosmetic changes involving moving declaration of variables to where they are first used, using temporaries to store common subexpressions, and more idiomatic array iteration.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 88 Primarily cosmetic changes to SSHTool. One minor functional change is that handleTerminateWithSelector:toObject:withInfo: now retains both theObject and theInfo to prevent them from disappearing out from under it. They are released when the task termination notification comes in.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 89 Ensure env refers to a valid array.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 90 Use an enum to store key type rather than an integer with a series of defines, and move key type discovery out of initWithPath and into a class method.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 91 Rename lastAdded + lastAddedLock to lastScheduled + lastScheduledLock as that makes more sense to me. A getter/setter have been added to keep the locking centralised.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 92 Code cleanup: remove unused code, actually allocate the locks in initWithPaths, add accessors for addingKeys, and simplify logic to reduce nested if/else statements.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 93 Refactor the guts of SSHAgent - handleAgentConnections and inputFromClient:. Big changes are giving variables more sensible names, moving declarations to first use, and simplifying logic to reduce levels of nested conditionals. This is a very invasive change, but I'm confident that behaviour is the same.   svn at sshkeychain.org
• [Svnwatch] SSHKeychain 94 Clean up formatting and minor logic changes in SSHTunnel.   svn at sshkeychain.org

Last message date: Wed Dec 28 16:46:18 CEST 2005
Archived on: Wed Dec 28 16:46:24 CEST 2005

• Messages sorted by: [ subject ] [ author ] [ date ]
• More info on this list...